-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spinal levels based on Frostell et al. paper #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcohenadad
changed the title
Update spinal levels
Update spinal levels based on Frostell et al. paper
Aug 4, 2023
9 tasks
This was referenced Oct 2, 2023
This was referenced Oct 10, 2023
As per #28 (comment), a suggestion would be to have:
|
Oops! on 38f6ce3 I noticed a value=1 at the very bottom: It extends for 9 slices. Probably related to the code, which rounds segment length and then accumulate errors going caudally: PAM50/scripts/generate_spinal_levels.py Line 94 in 38f6ce3
|
We can merge and fix spinalcordtoolbox/spinalcordtoolbox#4248 afterwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the spinal levels with an improved version. See full context in #16.
Generated with: d854c26
As the new spinal levels are integer (vs. the previous spinal levels which were probabilistic), they are contained within a single file located under
PAM50/template
(previouslyPAM50/spinal_levels
). The following changes are therefore necessary:PAM50_cord.nii.gz
is missing the caudal part #19PAM50_spinal_levels.nii.gz
underPAM50/template
PAM50/spinal_levels
sct_warp_template
, remove the option-s
because the spinal levels will be warped by default alongside all files underPAM50/template
Fixes #16
Related: #21