Skip to content

Commit

Permalink
Minor fixes: don't update removed items and always set list_value_id
Browse files Browse the repository at this point in the history
  • Loading branch information
manuelma committed Nov 27, 2023
1 parent 29ce79e commit e96f513
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions spinedb_api/db_mapping_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,8 @@ def cascade_update(self):
"""Updates this item and all its referrers in cascade.
Also, calls items' update callbacks.
"""
if self._removed:
return
self.call_update_callbacks()
for referrer in self._referrers.values():
referrer.cascade_update()
Expand Down
1 change: 1 addition & 0 deletions spinedb_api/mapped_items.py
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,7 @@ def resolve(self):
return d

def polish(self):
self["list_value_id"] = None
error = super().polish()
if error:
return error
Expand Down

0 comments on commit e96f513

Please sign in to comment.