Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise purging #262

Closed
soininen opened this issue Sep 6, 2023 · 1 comment
Closed

Optimise purging #262

soininen opened this issue Sep 6, 2023 · 1 comment
Assignees
@manuelma
Labels
enhancement New feature or request Mopo_data_structure
Milestone
v0.9.0

Comments

@soininen
Copy link
Collaborator

soininen commented Sep 6, 2023 •
edited
Loading

But also, maybe it is a mistake to implement purge_items based on remove_items, maybe purge should be its own operation? Like mark a table as purged in the cache, and then delete the entire contents of that table in the DB when committing. This would save enormous time eventually if the user purges a huge table. It is actually almost ridiculous to fetch all the rows just to say, okay, now remove them all.

Originally posted by @manuelma in #261 (comment)
@soininen soininen added enhancement New feature or request Mopo_data_structure labels Sep 6, 2023
@manuelma manuelma self-assigned this Sep 6, 2023
manuelma added a commit that referenced this issue Oct 19, 2023
@manuelma
Lazy purge - instead of fetching the entire table just to purge it...
05544b7 
...we mark the table as purged and then purge stuff as it is fetched
by the system.

Re #262
@jkiviluo jkiviluo added this to the v0.8.1 milestone Nov 22, 2023
@manuelma
Copy link
Collaborator

I think the lazy purge is working just fine? Will close, new issues will come out naturally if bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuelma manuelma

Labels
enhancement New feature or request Mopo_data_structure
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
3 participants
@manuelma @soininen @jkiviluo