Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce add_update and use it in import_data #320

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Conversation

manuelma
Copy link
Collaborator

@manuelma manuelma commented Nov 24, 2023

Fixes #305

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (dd0d4dc) 77.21% compared to head (90caffe) 77.09%.
Report is 4 commits behind head on 0.8-dev.

Files Patch % Lines
spinedb_api/db_mapping.py 82.50% 7 Missing ⚠️
spinedb_api/db_mapping_base.py 71.42% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           0.8-dev     #320      +/-   ##
===========================================
- Coverage    77.21%   77.09%   -0.13%     
===========================================
  Files           74       74              
  Lines         9244     9208      -36     
  Branches      1964     1947      -17     
===========================================
- Hits          7138     7099      -39     
- Misses        1773     1777       +4     
+ Partials       333      332       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelma manuelma merged commit 0626567 into 0.8-dev Nov 27, 2023
8 checks passed
@manuelma manuelma deleted the add_update branch November 27, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants