Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scenario filter for parameter values of multidimensional entities #468

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Nov 21, 2024

Scenario filter must drop parameter values of multidimensional entities that will be dropped by the filter because they have elements that are inactive in the scenario.

No associated issue

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Scenario filter must drop parameter values of multidimensional entities
that will be dropped by the filter because their elements are
dropped by the filter.
@soininen soininen force-pushed the fix_scenario_filter branch from 79c3c9a to 510414f Compare November 21, 2024 14:36
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.37%. Comparing base (b5f78bd) to head (510414f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   80.37%   80.37%           
=======================================
  Files          76       76           
  Lines       10023    10025    +2     
  Branches     1477     1477           
=======================================
+ Hits         8056     8058    +2     
  Misses       1625     1625           
  Partials      342      342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@soininen soininen merged commit 1564a61 into master Nov 21, 2024
12 of 13 checks passed
@soininen soininen deleted the fix_scenario_filter branch November 21, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant