WIP: Migrate to SQLAlchemy 1.4 #473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 80.48% 80.56% +0.07%
==========================================
Files 77 76 -1
Lines 9962 9884 -78
Branches 1477 1472 -5
==========================================
- Hits 8018 7963 -55
+ Misses 1602 1582 -20
+ Partials 342 339 -3 ☔ View full report in Codecov by Sentry. |
Migrated spinedb_api to use SQLAlchemy 1.4. - DatabaseMapping must now always be used with the 'with' block. This is because only then we create the connection and session instances. - We now use vanilla SQLAlchemy queries, our custom query module is gone. - DatabaseMapping's subqueries now return SQLAlchemy Result objects which is a BREAKING change. - We never really supported sending DatabaseMapping objects to multiprocessing.Process because DatabaseMapping is not picklable. This has been made more explicit now by removing a unit test that depended on the feature. - Some migrations towards SQLAlchemy 2.0 are included but we still get a lot of warnings with the SQLALCHEMY_WARN_20=1 environment variable. Re #121
soininen
force-pushed
the
sqlalchemy-1.4
branch
from
a896c96 to
00c870d
Compare
soininen
force-pushed
the
sqlalchemy-1.4
branch
from
950bf12 to
23bdb36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates
spinedb_apito SQLAlchemy 1.4.DatabaseMappingnow opens and closes a session only when needed. When using the low-level queries, the session must be opened manually usingDatabaseMappingas a context manager.querymodule is gone.DatabaseMapping's low-level subqueries now return SQLAlchemy'sResultobjects. The high-level functions work as previously.SQLALCHEMY_WARN_20=1environment variable.Resolves #121
Checklist before merging