Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize Tool type on Design View #2491

Closed
ptsavol opened this issue Jan 16, 2024 · 13 comments · Fixed by #2541
Closed

Visualize Tool type on Design View #2491

ptsavol opened this issue Jan 16, 2024 · 13 comments · Fixed by #2541
Assignees
Labels

Comments

@ptsavol
Copy link
Member

ptsavol commented Jan 16, 2024

We need to visualize the Tool type (Julia, Python, Gams, Executable) on Design View in a better way. You can see the problem in the picture below, where tool A is a Python Tool, tool B is a Julia Tool, C is a Gams Tool, and D is an Executable Tool. All Tools here look identical so it would be nice to see which is which. There is a label in Tool properties, which does say that A is a Python tool but it's not ideal.

new_issue_visualize_tool_spec_type

The idea at the moment is to add a Python, Julia, Executable or Gams icon in the same box as the hammer but I'm open for other ideas as well.

@ptsavol ptsavol added the UI label Jan 16, 2024
@ptsavol ptsavol self-assigned this Jan 16, 2024
ptsavol added a commit that referenced this issue Jan 17, 2024
ptsavol added a commit to spine-tools/spine-items that referenced this issue Jan 17, 2024
ptsavol added a commit to spine-tools/spine-items that referenced this issue Jan 18, 2024
ptsavol added a commit to spine-tools/spine-engine that referenced this issue Jan 18, 2024
@ptsavol
Copy link
Member Author

ptsavol commented Jan 18, 2024

Python, Julia, Gams, and Executable icons are now shown under Tools on Design View. Looks a lot better IMO.

@ptsavol ptsavol closed this as completed Jan 18, 2024
@soininen
Copy link
Contributor

soininen commented Jan 18, 2024

It looks cool, indeed! However, we may want to reconsider the icon's placement:

image

Can we somehow squeeze tool type icons inside the item icon so it will not get obstructed behind the link arrows etc.?

@soininen soininen reopened this Jan 18, 2024
@ptsavol
Copy link
Member Author

ptsavol commented Jan 19, 2024

Can we somehow squeeze tool type icons inside the item icon so it will not get obstructed behind the link arrows etc.?

This was the intention originally but the tool item insides are getting a bit crowded. Only vacant places inside the item icon are the red circles in the picture below.

issue_2491_spec_icon_placement

I can try and tweak it a bit and see how it looks.

@jkiviluo
Copy link
Member

I'd prefer the location inside the tool icon, bottom left maybe (or top right).

@ptsavol
Copy link
Member Author

ptsavol commented Jan 19, 2024

I'd prefer the location inside the tool icon, bottom left maybe (or top right).

Top right is reserved for notifications (exclamation mark in a red circle).

@ptsavol
Copy link
Member Author

ptsavol commented Jan 29, 2024

Which one's the best?

issue_2491_option1

issue_2491_option2

issue_2491_option3

issue_2491_option4

@soininen
Copy link
Contributor

soininen commented Jan 30, 2024

Which one's the best?

1 or 4. Perhaps I'd go with 4. The icon is getting pretty busy.

@jkiviluo
Copy link
Member

We also have a problem with tool names taking too much space. It can be hard to find the right spot for the tool when one is using descriptive long names. #4 makes it bit longer still. So, I think I'd prefer 1 or 2, perhaps 2 bit more, since it feels more FYI there.

@soininen
Copy link
Contributor

We also have a problem with tool names taking too much space.

Would it help if the name was rendered on multiple lines?

@jkiviluo
Copy link
Member

jkiviluo commented Jan 30, 2024

Would it help if the name was rendered on multiple lines?

It would be better - keeping the width of the text closer to the width of the icon (can be like 20-40% wider).

@manuelma
Copy link
Collaborator

manuelma commented Jan 31, 2024

How about this, icon centered on the bottom left corner:

image

@ptsavol
Copy link
Member Author

ptsavol commented Feb 1, 2024

I think @manuelma's suggestion wins. I made the change.

ptsavol added a commit that referenced this issue Feb 1, 2024
Write item name on Design View on multiple lines

Re #2491
@ptsavol
Copy link
Member Author

ptsavol commented Feb 1, 2024

Would it help if the name was rendered on multiple lines?

It would be better - keeping the width of the text closer to the width of the icon (can be like 20-40% wider).

Long names are now on multiple lines. Please reopen if not working as expected.

@ptsavol ptsavol closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants