Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up filtering #2569

Merged
merged 6 commits into from
Feb 11, 2024
Merged

Speed up filtering #2569

merged 6 commits into from
Feb 11, 2024

Conversation

manuelma
Copy link
Collaborator

@manuelma manuelma commented Feb 10, 2024

Makes filtering fast in db editor.

Checklist before merging

  • Documentation is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1adf9d5) 63.53% compared to head (d8b7c19) 63.48%.
Report is 2 commits behind head on 0.8-dev.

Files Patch % Lines
...lbox/spine_db_editor/widgets/stacked_view_mixin.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           0.8-dev    #2569      +/-   ##
===========================================
- Coverage    63.53%   63.48%   -0.05%     
===========================================
  Files          196      196              
  Lines        35848    35792      -56     
  Branches      6088     6074      -14     
===========================================
- Hits         22775    22724      -51     
+ Misses       11874    11868       -6     
- Partials      1199     1200       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelma manuelma merged commit b16dd2b into 0.8-dev Feb 11, 2024
16 checks passed
@manuelma manuelma deleted the speed_up_filtering branch February 11, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants