Enable string normalization in Black #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just reformatting, no functional changes. Re #2684
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.8-dev #2685 +/- ##
===========================================
- Coverage 65.38% 65.35% -0.03%
===========================================
Files 194 194
Lines 35542 35542
Branches 6038 6038
===========================================
- Hits 23238 23229 -9
- Misses 11071 11081 +10
+ Partials 1233 1232 -1 ☔ View full report in Codecov by Sentry. |
ptsavol
reviewed
Apr 2, 2024
| # Invalid characters for file names | ||
| INVALID_FILENAME_CHARS = ["<", ">", ":", "\"", "/", "\\", "|", "?", "*"] | ||
| INVALID_FILENAME_CHARS = ["<", ">", ":", '"', "/", "\\", "|", "?", "*"] |
There was a problem hiding this comment.
@soininen This change looks suspicious to me...
There was a problem hiding this comment.
It is the "pythonic" way :) Works fine, by the way.
There was a problem hiding this comment.
Yes, seems to be working fine. Should have tried it before dropping a line. Thanks and sorry for unnecessary messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just reformatting, no functional changes.
Re #2684
Checklist before merging