Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply review suggestions for economic representation calculation #1130

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

gnawin
Copy link
Collaborator

@gnawin gnawin commented Nov 1, 2024

Fixes #1095

Checklist before merging

  • Documentation is up-to-date
  • Unit tests have been added/updated accordingly
  • Code has been formatted according to SpineOpt's style
  • Unit tests pass

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.30%. Comparing base (7bc3fcf) to head (b330d27).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
src/data_structure/economic_structure.jl 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
- Coverage   87.33%   87.30%   -0.04%     
==========================================
  Files         143      143              
  Lines        4137     4134       -3     
==========================================
- Hits         3613     3609       -4     
- Misses        524      525       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gnawin gnawin marked this pull request as ready for review November 1, 2024 16:51
@gnawin gnawin requested review from manuelma and tarskul November 1, 2024 16:51
@gnawin gnawin requested a review from Tasqu November 19, 2024 13:09
@tarskul tarskul merged commit 739baf6 into master Nov 19, 2024
7 checks passed
@tarskul tarskul deleted the 1095-apply-review-suggestions-economic-parameters branch November 19, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with code for computing multi year economic parameter values
2 participants