-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefix log lines with spin and component-id #1116
Comments
Apologies for the pedantry but... the specific Spin output lines you quote are not logs - they are written directly as actionable information for the user. They should not receive logging-style decoration and their layout should be preserved (or at least modified only consciously). Obviously this does not affect the broader issue - it relates purely to the example. |
good point. I updated the description to be more clear. |
I'm not in favour of decorating normal user interaction this way. If we're going to decorate stuff, it should be the stuff you only use for diagnostics when something's gone wrong, not the stuff you see as part of normal operation and that is intended to be interacted with. |
Related discussion on Discord: https://discord.com/channels/926888690310053918/1081227946976616528/1081234846430535721
|
+1 on additional information on which component a log line originated from. |
resolves spinframework#1116 Signed-off-by: Michelle Dhanani <michelle@fermyon.com> Co-authored-by: Brian Hardock <brian.hardock@fermyon.com>
resolves spinframework#1116 Signed-off-by: Michelle Dhanani <michelle@fermyon.com>
It's hard to tell which
log linesoutput comes from Spin vs from the actual application (a component). It'd be nice to prefixlog linesoutput with this information:[Spin]
and[Component-ID]
For example, if we were to the run the example http rust app which has a single component called
hello
, thelogslooks like this:With the component-id and spin prefixes, the
logsoutput would look like this.Would appreciate any feedback here.
The text was updated successfully, but these errors were encountered: