Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SPIN_OCI_SKIP_INLINED_FILES the default #1781

Closed
lann opened this issue Sep 19, 2023 · 1 comment · Fixed by #1821
Closed

Make SPIN_OCI_SKIP_INLINED_FILES the default #1781

lann opened this issue Sep 19, 2023 · 1 comment · Fixed by #1821
Labels
Consider-for-2.0

Comments

@lann
Copy link
Collaborator

lann commented Sep 19, 2023

This was made opt-in via env var for testing and integration here: https://github.com/fermyon/spin/blob/631e32ff28477c01013a621ea41edb21ccabfdc8/crates/oci/src/client.rs#L78

We should make this the default "soonish" so that spin registry push will work for those registries that don't handle tiny layers.
@lann
Copy link
Collaborator Author

lann commented Sep 19, 2023

@vdice FYI

@michelleN michelleN moved this to 🆕 Triage Needed in Spin Triage Sep 20, 2023
@michelleN michelleN moved this from 🆕 Triage Needed to 🔖 Backlog in Spin Triage Sep 20, 2023
@melissaklein24 melissaklein24 moved this to 🆕 New in Spin 2.0 Sep 21, 2023
@vdice vdice mentioned this issue Sep 27, 2023
Merged
@melissaklein24 melissaklein24 moved this from 🆕 New to Must Haves in Spin 2.0 Sep 27, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Backlog to ✅ Done in Spin Triage Oct 2, 2023
@vdice vdice moved this from Must Haves to ✅ Done in Spin 2.0 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Consider-for-2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(oci): inline content when applicable by default vdice/spin
1 participant
@lann