Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oci): inline content when applicable by default #1821

Merged
merged 1 commit into from
Oct 2, 2023
Merged

feat(oci): inline content when applicable by default #1821

merged 1 commit into from
Oct 2, 2023

Conversation

vdice
Copy link
Contributor

@vdice vdice commented Sep 27, 2023

Closes #1781

@vdice
Copy link
Contributor Author

vdice commented Sep 27, 2023

As I think on it, is there any chance we'd still want users to be able to turn this 'feature' off (eg SPIN_OCI_SKIP_INLINED_FILES=false)? Perhaps if there are other consumers of spin apps-as-represented-in-oci-object-form who may be disrupted by missing layers (when they've been inlined into the locked app manifest).

@vdice vdice requested a review from lann September 27, 2023 19:42
lann
lann approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@lann lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly either way.

@vdice
Copy link
Contributor Author

vdice commented Sep 27, 2023

I don't feel strongly either way.

We can always add support at a later date for turning off this default behavior, should it be desired.

@vdice
feat(oci): inline content when applicable by default
ebf8d89 
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice force-pushed the feat/oci-inline-default branch from 212e5ac to ebf8d89 Compare October 2, 2023 19:33
@vdice vdice merged commit 0306346 into spinframework:main Oct 2, 2023
@vdice vdice deleted the feat/oci-inline-default branch October 2, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lann lann lann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make SPIN_OCI_SKIP_INLINED_FILES the default
2 participants
@vdice @lann