Remove template custom filters feature

crates/templates/Cargo.toml

@@ -32,10 +32,3 @@ tokio = { version = "1.23", features = ["fs", "process", "rt", "macros"] }
 toml = "0.5"
 url = "2.2.2"
 walkdir = "2"
-wasmtime = { workspace = true }
-wasmtime-wasi = { workspace = true }
-
-[dependencies.wit-bindgen-wasmtime]
-git = "https://github.com/fermyon/wit-bindgen-backport"
-rev = "598cd229bb43baceff9616d16930b8a5a3e79d79"
-features = ["async"]

crates/templates/src/lib.rs

@@ -5,7 +5,6 @@
 mod app_info;
 mod cancellable;
 mod constraints;
-mod custom_filters;
 mod directory;
 mod environment;
 mod filters;

crates/templates/src/manager.rs

@@ -56,6 +56,7 @@ enum ExistsBehaviour {
     Update,
 }
 
+#[allow(clippy::large_enum_variant)] // it's not worth it
 enum InstallationResult {
     Installed(Template),
     Skipped(String, SkippedReason),
@@ -828,43 +829,26 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn can_use_custom_filter_in_template() {
+    async fn cannot_use_custom_filter_in_template() {
         let temp_dir = tempdir().unwrap();
         let store = TemplateStore::new(temp_dir.path());
         let manager = TemplateManager { store };
         let source = TemplateSource::File(test_data_root());
 
-        manager
+        let install_results = manager
             .install(&source, &InstallOptions::default(), &DiscardingReporter)
             .await
             .unwrap();
 
-        let template = manager.get("testing-custom-filter").unwrap().unwrap();
+        assert_eq!(1, install_results.skipped.len());
 
-        let dest_temp_dir = tempdir().unwrap();
-        let output_dir = dest_temp_dir.path().join("myproj");
-        let values = [
-            ("p1".to_owned(), "biscuits".to_owned()),
-            ("p2".to_owned(), "nomnomnom".to_owned()),
-        ]
-        .into_iter()
-        .collect();
-        let options = RunOptions {
-            variant: crate::template::TemplateVariantInfo::NewApplication,
-            output_path: output_dir.clone(),
-            name: "custom-filter-test".to_owned(),
-            values,
-            accept_defaults: false,
+        let (id, reason) = &install_results.skipped[0];
+        assert_eq!("testing-custom-filter", id);
+        let SkippedReason::InvalidManifest(message) = reason else {
+            panic!("skip reason should be InvalidManifest"); // clippy dislikes assert!(false...)
         };
-
-        template.run(options).silent().await.unwrap();
-
-        let message = tokio::fs::read_to_string(output_dir.join("test.txt"))
-            .await
-            .unwrap();
-        assert!(message.contains("p1/studly = bIsCuItS"));
-        assert!(message.contains("p2/studly = nOmNoMnOm"));
-        assert!(message.contains("p1/clappy = b👏i👏s👏c👏u👏i👏t👏s"));
+        assert_contains(message, "filters");
+        assert_contains(message, "not supported");
     }
 
     #[tokio::test]

crates/templates/src/reader.rs

@@ -22,7 +22,7 @@ pub(crate) struct RawTemplateManifestV1 {
     pub new_application: Option<RawTemplateVariant>,
     pub add_component: Option<RawTemplateVariant>,
     pub parameters: Option<IndexMap<String, RawParameter>>,
-    pub custom_filters: Option<Vec<RawCustomFilter>>,
+    pub custom_filters: Option<serde::de::IgnoredAny>, // kept for error messaging
 }
 
 #[derive(Debug, Deserialize)]
@@ -45,13 +45,6 @@ pub(crate) struct RawParameter {
     pub pattern: Option<String>,
 }
 
-#[derive(Debug, Deserialize)]
-#[serde(deny_unknown_fields, rename_all = "snake_case")]
-pub(crate) struct RawCustomFilter {
-    pub name: String,
-    pub wasm: String,
-}
-
 pub(crate) fn parse_manifest_toml(text: impl AsRef<str>) -> anyhow::Result<RawTemplateManifest> {
     toml::from_str(text.as_ref()).context("Failed to parse template manifest TOML")
 }

crates/templates/src/run.rs

@@ -308,14 +308,11 @@ impl Run {
     }
 
     fn template_parser(&self) -> liquid::Parser {
-        let mut builder = liquid::ParserBuilder::with_stdlib()
+        let builder = liquid::ParserBuilder::with_stdlib()
             .filter(crate::filters::KebabCaseFilterParser)
             .filter(crate::filters::PascalCaseFilterParser)
             .filter(crate::filters::SnakeCaseFilterParser)
             .filter(crate::filters::HttpWildcardFilterParser);
-        for filter in self.template.custom_filters() {
-            builder = builder.filter(filter);
-        }
         builder
             .build()
             .expect("can't fail due to no partials support")