Fix misleading guidance on disallowed host #2006
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you make a HTTP request to a disallowed host, Spin currently recommends that you add
https://whatever:{80|443}
(default port for your scheme) to your AOH. E.g.This PR displays the original scheme of the request, and the custom port if one was used:
Apologies for the lack of tests. The function is a bit monolithic at the moment; after release, we can look into factoring out more testable bits such as the validation/error routine.