Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests/integration): update plugin output assertion #2047

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

vdice
Copy link
Contributor

@vdice vdice commented Nov 3, 2023

I was unable to successfully run the integration tests on my machine (Mac Apple Silicon; same with @adamreese I believe), seeing the following:

failures:

---- integration_tests::test_spin_plugin_install_command stdout ----
STDOUT:
Plugin 'example' was installed successfully!

Description:
	A description of the plugin.

STDERR:
Warning: You're using a pre-release version of Spin (2.0.0-pre0). This plugin might not be compatible (supported: >=0.5). Continuing anyway.

STDOUT:
This is an example Spin plugin!

STDERR:
Warning: You're using a pre-release version of Spin (2.0.0-pre0). This plugin might not be compatible (supported: >=0.5). Continuing anyway.

thread 'integration_tests::test_spin_plugin_install_command' panicked at tests/integration.rs:595:9:
assertion `left == right` failed
  left: "\u{1b}(B\u{1b}[m\u{1b}(B\u{1b}[mThis is an example Spin plugin!"
 right: "This is an example Spin plugin!"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    integration_tests::test_spin_plugin_install_command

This proposes tweaking the assertion to use contains instead.

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice merged commit 61217c2 into spinframework:main Nov 7, 2023
@vdice vdice deleted the fix/integration-test-plugin-output branch November 7, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants