Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forked Wasmtime 14.0.4 with backported fixes #2076

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

lann
Copy link
Collaborator

@lann lann commented Nov 9, 2023

This fork of wasmtime 14.0.4 includes backports of upstream fixes:

bytecodealliance/wasmtime#7426
bytecodealliance/wasmtime#7475

Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann
Copy link
Collaborator Author

lann commented Nov 9, 2023

e2e-tests failure reproduces locally and is confusing:

Error: Failed to instantiate component 'hello'

Caused by:
      cannot adapt modules created with wit-bindgen version 0.13.0

@alexcrichton
Copy link
Contributor

Where are you getting those error logs from? From reading over the error here I think it will require the final commit of #2037 which fixes some guest SDK behavior w.r.t reads/writes

@dicej
Copy link
Contributor

dicej commented Nov 9, 2023

cannot adapt modules created with wit-bindgen version 0.13.0

Sounds like an old version of spin-componentize is sneaking in somewhere. The latest version should accept components built with either wit-bindgen 0.2 or 0.5 and above.

@lann
Copy link
Collaborator Author

lann commented Nov 9, 2023

Oh strange; I reran just the one failing test locally and got the above error, but if I run the whole suite there are lots of errors so probably unrelated.

Signed-off-by: Alex Crichton <alex@alexcrichton.com>
@lann lann force-pushed the backported-wasmtime branch from 3331f65 to d824565 Compare November 9, 2023 19:01
@lann
Copy link
Collaborator Author

lann commented Nov 9, 2023

cannot adapt modules created with wit-bindgen version 0.13.0

Sounds like an old version of spin-componentize is sneaking in somewhere. The latest version should accept components built with either wit-bindgen 0.2 or 0.5 and above.

I've been switching between 1.5.1 and 2.0.0 a lot locally; possibly a bad dep cache.

@lann lann merged commit 3fbff44 into main Nov 9, 2023
@lann lann deleted the backported-wasmtime branch November 9, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants