fix non-streaming outgoing POST requests in Rust SDK #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was my fault for over-simplifying the code in `spin_sdk::http::send`. I've added a test to make sure this stays fixed. Fixed spinframework#2080 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
lann
approved these changes
Nov 10, 2023
rylev
reviewed
Nov 23, 2023
| body_sink | ||
| .send(body_buffer) | ||
| .await | ||
| .map_err(|e| SendError::Http(Error::UnexpectedError(e.to_string())))?; | ||
| response | ||
| drop(body_sink); |
There was a problem hiding this comment.
We should comment why the explicit drop is needed so we're not tempted in the future to remove it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was my fault for over-simplifying the code in
spin_sdk::http::send. I've added a test to make sure this stays fixed.Fixed #2080