Port sqlite-libsql to new libsql client #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
reviewed
Dec 7, 2023
crates/sqlite-libsql/Cargo.toml
Outdated
| @@ -13,5 +13,5 @@ rusqlite = { version = "0.29.0", features = [ "bundled" ] } | |||
| spin-sqlite = { path = "../sqlite" } | |||
| spin-world = { path = "../world" } | |||
| sqlparser = "0.34" | |||
| libsql-client = { version = "0.31.5", features = ["reqwest_backend"], default_features = false } | |||
| libsql = { git = "https://github.com/tursodatabase/libsql", rev = "c5765fe3770023ead42b0839527f6bc02161e224" } | |||
There was a problem hiding this comment.
Suggested change
| libsql = { git = "https://github.com/tursodatabase/libsql", rev = "c5765fe3770023ead42b0839527f6bc02161e224" } | |
| libsql = { git = "https://github.com/tursodatabase/libsql", rev = "c5765fe3770023ead42b0839527f6bc02161e224", feature = ["remote"], default-features = false } |
Applying this should make libsql much easier to compile since it won't compile any of the C code and it will only build the http based code.
There was a problem hiding this comment.
@LucioFranco At the moment, it looks like it's still pulling in libsql-sys and thereby libsql-ffi which are failing on Windows. I've done a cargo update but it's still showing up as a libsql dependency (and nothing else seems to be bringing those crates in). Any advice appreciated - thanks!
itowlson
force-pushed
the
libsql-new-library
branch
5 times, most recently
from
2b2d9a1 to
a5109eb
Compare
itowlson
force-pushed
the
libsql-new-library
branch
from
a5109eb to
c543d54
Compare
|
The 0.2 release looks to be taking a while so putting this out for review anyway |
rylev
approved these changes
Dec 18, 2023
itowlson
force-pushed
the
libsql-new-library
branch
from
c543d54 to
7ddeef7
Compare
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
libsql-new-library
branch
from
7ddeef7 to
85c3359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a git reference for testing - a release is promised soon.
This should address all the dreaded
sqlite3-parserbuild errors that have affected downstream consumers of the Spin runtime when Cargo has helpfully locked them to a more recent version oflibsql-client-rs.