Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outbound postgres runtime tests #2150

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Outbound postgres runtime tests #2150

merged 3 commits into from
Dec 11, 2023

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Dec 7, 2023

New outbound postgres runtime tests that replace the now deleted end to end tests.

@rylev rylev requested a review from rajatjindal December 7, 2023 17:00
@rylev rylev force-pushed the outbound-postgres-runtime-test branch 2 times, most recently from 0216e62 to 3d03b20 Compare December 8, 2023 14:41
Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I suggested one thing I'd like to add, but it wasn't in the existing tests so it's not a regression or anything - could easily be added as a separate enhancement.

Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
These have been replaced by new runtime tests.

Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
@rylev rylev force-pushed the outbound-postgres-runtime-test branch from 3d03b20 to dfab4ec Compare December 11, 2023 10:56
@rylev rylev merged commit de7d847 into main Dec 11, 2023
@rylev rylev deleted the outbound-postgres-runtime-test branch December 11, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants