Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double backslashes in printed Windows paths #2162

Merged

Conversation

itowlson
Copy link
Collaborator

Fixes #2158.

This changes user-facing messages (errors and prints; I skipped logs) to print paths correctly on Windows.

# Before
Logging component stdio to ".\\target\\..\\..\\dirmounttest\\.spin\\logs\\"
# After
Logging component stdio to .\target\..\..\dirmounttest\.spin\logs\

@itowlson itowlson force-pushed the fix-windows-double-backslashes branch 2 times, most recently from a5511ef to f71dcbd Compare December 12, 2023 04:04
Copy link
Collaborator

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this change overall. We've had some debate about the right way to print paths, and I think this settles that debate. That being said, I do think we likely want to keep double quotes around paths as that usually makes it easier for readers to parse.

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson force-pushed the fix-windows-double-backslashes branch from f71dcbd to c5ac337 Compare December 12, 2023 20:17
@itowlson itowlson requested a review from rylev December 12, 2023 20:27
@itowlson itowlson enabled auto-merge December 12, 2023 21:08
@itowlson itowlson merged commit fc417e1 into spinframework:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doubled backslashes in some Windows messages
2 participants