Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): only upload spin static bin to release if semver tag #2169

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

vdice
Copy link
Contributor

@vdice vdice commented Dec 13, 2023

  • Only upload spin static bin to GH release if associated with a v* tag

Without this fix, merges to main will create a main tag and release (which we should delete which I've deleted).

The spin static canary builds will still be collected as normal and attached to the canary release during the update-canary job.

Test on fork: https://github.com/vdice/spin/actions/runs/7201886432; see also https://github.com/vdice/spin/releases/tag/canary

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice enabled auto-merge (squash) December 13, 2023 23:12
@vdice vdice merged commit 7b8af17 into spinframework:main Dec 13, 2023
@vdice vdice deleted the ci/spin-static-release-upload branch December 13, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants