Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print error msg when plugin binary is missing #2189

Merged
merged 1 commit into from
Dec 20, 2023
Merged

print error msg when plugin binary is missing #2189

merged 1 commit into from
Dec 20, 2023

Conversation

rajatjindal
Copy link
Contributor

No description provided.

@rajatjindal rajatjindal requested a review from itowlson December 19, 2023 01:40
itowlson
itowlson requested changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content is fine - thanks! Just a couple of style niggles that it would be good to clear up - sorry.

@rajatjindal
print error msg when binary is missing
d8b5d04 
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
@rajatjindal rajatjindal force-pushed the error-if-plugin-binary-missing branch from 9fa68dc to d8b5d04 Compare December 19, 2023 06:03
@rajatjindal rajatjindal changed the title print error msg when binary is missing print error msg when plugin binary is missing Dec 19, 2023
@rajatjindal
Copy link
Contributor Author

thanks for the review Ivan. I have addressed the review comments. made a small change in error msg to include the plugin name explicitly. I hope that is ok.

@rajatjindal rajatjindal requested a review from itowlson December 19, 2023 06:21
itowlson
itowlson approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks grand now - thanks!

@rajatjindal rajatjindal merged commit 5639597 into spinframework:main Dec 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson itowlson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajatjindal @itowlson