-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Send
and Sync
bounds from Rust SDK router
#2198
Conversation
These bounds were preventing users from calling async functions which use `http::executor` since it uses `Rc<RefCell<_>>` internally, which is neither `Send` nor `Sync`. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
I still got the same error with
I build from source now. So my spin has this merge in. |
@seungjin The version of Spin you use doesn't matter in this case -- it's the spin_sdk version that matters. Would you please double-check that you're using a version of spin_sdk that contains this fix? |
In my Cargo.toml
Did |
Did with (in my Cargo.toml)
and compile was succeeded!! |
Isn't the code in the main branch?? |
The main branch has it. You may need to run |
Yep. Figured out it is lock file. Working back now. |
Compile was succeed and I deployed and tested. |
Never mind.. Working.. had two spin running.. some indirection happened. |
These bounds were preventing users from calling async functions which use
http::executor
since it usesRc<RefCell<_>>
internally, which is neitherSend
norSync
.See https://discord.com/channels/926888690310053918/1187255600002891798 for details.