feat(cli.rs): allow setting app log dir via SPIN_LOG_DIR env var #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
reviewed
Jan 3, 2024
crates/trigger/src/cli.rs
Outdated
| @@ -43,6 +43,7 @@ where | |||
| #[clap( | |||
| name = APP_LOG_DIR, | |||
| short = 'L', | |||
| env = APP_LOG_DIR, | |||
There was a problem hiding this comment.
For an environment variable I'd consider SPIN_LOG_DIR (as Hippo used) rather than APP_LOG_DIR. Reduces the risk of a clash, and makes it easier for someone poring through the environment to understand what the variable relates to.
There was a problem hiding this comment.
(to be clear APP_LOG_DIR is fine for the name because that only gets used when printing help strings, at which point the user is strictly in the context of spin up... I am just wary of it as a name in the global environment)
vdice
force-pushed
the
feat/app-log-dir-env
branch
from
dcb4e37 to
179fa36
Compare
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
vdice
force-pushed
the
feat/app-log-dir-env
branch
from
179fa36 to
2c5b190
Compare
vdice
changed the title
itowlson
approved these changes
Jan 3, 2024
fibonacci1729
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIN_LOG_DIRenv varUnsure if it was an intentional decision to not allow setting via env var, though?
I happened to notice this when deploying to the OSS Fermyon Platform, using Hippo, which attempts to set this env var: https://github.com/deislabs/hippo/blob/main/src/Infrastructure/Services/NomadJobService.cs#L189