Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove credentials before printing Redis subscriptions #2349

Merged

Conversation

itowlson
Copy link
Collaborator

Fixes #2341.

@seungjin can you test this please? I don't have a Redis instance that accepts credentials, and due to a separate issue that seems to prevent me from checking the output. Thanks!

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson requested review from lann and karthik2804 March 11, 2024 21:32
Copy link
Contributor

@karthik2804 karthik2804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using a redis-labs instance and it looks good!

@itowlson
Copy link
Collaborator Author

Aha, thank you for the proper test @karthik2804!

@itowlson itowlson merged commit 15a2575 into spinframework:main Mar 12, 2024
15 checks passed
@seungjin
Copy link

# spin --version
spin 2.4.0-pre0 (e82985ba 2024-03-12)

AND 

Active Channels on redis://redis-XXXXX.XXX.ap-northeast-1-2.ec2.cloud.redislabs.com:12537:
	redis://redis-XXXXX.XXX.ap-northeast-1-2.ec2.cloud.redislabs.com:12537:postbox: [postbox]

Works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spin up command prints out my redis credintial in plain text
3 participants