Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less worse error if file mount source doesn't exist #2384

Conversation

itowlson
Copy link
Collaborator

An ickle wee error message tweak relating to #1022.

Previously:

Error: Failed to load manifest from "spin.toml"

Caused by:
   0: Failed to load Spin app from "spin.toml"
   1: Failed to load component `fstest`
   2: invalid file mount source "assets"
   3: No such file or directory (os error 2)

With this PR:

Error: Failed to load manifest from "spin.toml"

Caused by:
   0: Failed to load Spin app from "spin.toml"
   1: Failed to load component `fstest`
   2: File or directory "assets" does not exist

(Yes, I would like to simplify the stack further, especially those first two lines, but that's a separate issue.)

Signed-off-by: itowlson <ivan.towlson@fermyon.com>
@itowlson itowlson force-pushed the improve-error-when-mount-dir-doesnt-exist branch from 7b05442 to 28fa7c4 Compare March 20, 2024 00:38
@itowlson itowlson merged commit 20c9c8a into spinframework:main Mar 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants