Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): update versions for v2.5.0-pre0 #2400

Conversation

kate-goldenring
Copy link
Contributor

@kate-goldenring
Copy link
Contributor Author

@dicej i am not sure why the linting is failing here. i ran make build update-cargo-locks and PR looks similar to #2312. Plus running the step locally passes. I am going to try rerunning it

@kate-goldenring
Copy link
Contributor Author

Linting is failing due to this issue: #2401

Passed locally and inside a ubuntu 20.04 container

@lann
Copy link
Collaborator

lann commented Mar 28, 2024

I tried to fix this with #2383; could you rebase this PR and try again?

@kate-goldenring kate-goldenring force-pushed the update-versions-for-v2.5.0-pre branch from 3d40e5d to 62c8284 Compare March 28, 2024 14:55
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
@kate-goldenring kate-goldenring force-pushed the update-versions-for-v2.5.0-pre branch from 62c8284 to 57c2a57 Compare March 28, 2024 16:07
@kate-goldenring kate-goldenring merged commit ad8e68a into spinframework:main Mar 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants