Allow template to have tmpl extension #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
lann
approved these changes
Apr 15, 2024
crates/templates/src/run.rs
Outdated
| // Strip optional .tmpl extension | ||
| // Templates can use this if they don't want to store files with their final extensions | ||
| let paths = paths.into_iter().map(|p| { | ||
| if p.extension().map(|e| e == "tmpl").unwrap_or_default() { |
There was a problem hiding this comment.
This is an option now (Rust 1.70):
Suggested change
| if p.extension().map(|e| e == "tmpl").unwrap_or_default() { | |
| if p.extension().is_some_and(|e| e == "tmpl") { |
There was a problem hiding this comment.
Where are we documenting Spin's MSRV? CI is testing 1.74 but the contributing docs say 1.68. I assume the contributing docs are just out of date?
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2455
The template handler will automatically strip the
.tmplextension.