Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factors: Break up the Error::RuntimeFactorError monopoly #2645

Merged
merged 1 commit into from
Jul 15, 2024
Merged

factors: Break up the Error::RuntimeFactorError monopoly #2645

merged 1 commit into from
Jul 15, 2024

Conversation

lann
Copy link
Collaborator

@lann lann commented Jul 15, 2024

No description provided.

@lann
factors: Break up the Error::RuntimeFactorError monopoly
ef3f87d 
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann requested a review from rylev July 15, 2024 14:21
calebschoepp
calebschoepp approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@calebschoepp calebschoepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always was a fan of the Sherman act.

@lann lann merged commit d74bd80 into spinframework:factors Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebschoepp calebschoepp calebschoepp approved these changes

@rylev rylev Awaiting requested review from rylev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lann @calebschoepp