factors: Pare down spin-core and spin-app #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Jul 19, 2024
crates/core/src/host_component.rs
Outdated
There was a problem hiding this comment.
The HostComponent is dead! Long live the Factor!
Comment on lines
+130
to
+142
| let locked: LockedApp = serde_json::from_value(json!({ | ||
| "spin_lock_version": 1, | ||
| "triggers": [], | ||
| "components": [{ | ||
| "id": "test-component", | ||
| "source": { | ||
| "content_type": "application/wasm", | ||
| "content": {}, | ||
| }, | ||
| }] | ||
| }))?; | ||
| let app = App::new("test-app", locked); | ||
| let configured_app = factors.configure_app(app, ())?; |
lann
force-pushed
the
factors-die-code-die
branch
from
21325c3 to
0df8436
Compare
These features are moving as part of the migration to factors. Signed-off-by: Lann Martin <lann.martin@fermyon.com>
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
factors-die-code-die
branch
from
0df8436 to
7708b03
Compare
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
factors-die-code-die
branch
from
7708b03 to
e2334e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These features are moving as part of the migration to factors.
Notably, the spin-core integration test now shows roughly how factors will be integrated with core in spin-trigger.