-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break circular dependency between http
and testing
crates
#2668
Break circular dependency between http
and testing
crates
#2668
Conversation
fdc30a1
to
53a2b8d
Compare
The first take on this PR failed because something brought in a new version of |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
53a2b8d
to
1c8fb60
Compare
Revved it to the latest commit on conformance-tests and somehow that didn't seem to bring back the AWS dependency so heaven knows where that came from. Maybe the main pointer was picking up some crazy local cache thing while generating the lockfile. Anyway pushed with that later rev and WE SHALL SEE. |
Okay I am not sure what is going on with that AWS library ( The cc build issue was raised in a now-closed issue with the rustls maintainers, whose reponse was basically "sucks to be you." So it's not gonna be fixed, and we can't avoid running @rylev After determining that AWS was unrelated to conformance-tests, I tried resetting the conformance-tests dependency back to main, but once again rust-analyser started complaining with the errors: So I am leaving this PR with the pinned SHA. But happy to take your guidance on this. Sorry for all the faff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the hassle here! I'd actually like to get away from using branch in the Cargo.toml and instead pin to specific revs. I've done this in my branch here: #2663, so I think this is totally fine.
I'm going to merge this (the CI failure is a known issue and unrelated to the change here). |
I'm not sure quite what was going on here (well, that's always a reassuring start to a PR) but updating to latest
main
made rust-analyser weird and unresponsive and unwilling to load updated dependencies. There were a lot of errors in the log about a circular dependency. I couldn't see where the http->testing dependency was used, and when I broke it, nothing seemed to fail, and rust-analyser seemed a lot happier. So here it is - if I'm missing something, please let me know (if CI doesn't tell me first!).(The change revved a bunch of unrelated stuff in
Cargo.lock
. I'm not sure if that's anything we need to worry about but just so you know.)