Set initial key-values #2716
Merged
Set initial key-values #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
lann
approved these changes
Aug 15, 2024
Comment on lines
+205
to
+207
| runtime_config | ||
| .set_initial_key_values(&self.key_values) | ||
| .await?; |
There was a problem hiding this comment.
May be out of scope for this PR, but I think we should probably support something like:
[key_value_store.default]
type = "none"...which would then suggest doing something like:
Suggested change
| runtime_config | |
| .set_initial_key_values(&self.key_values) | |
| .await?; | |
| if !self.key_values.is_empty() { | |
| runtime_config | |
| .set_initial_key_values(&self.key_values) | |
| .await?; | |
| } |
There was a problem hiding this comment.
Is this point of such a feature to ensure that a default store never gets created? If the key-value interface gets used with the default store is it expected to just error?
There was a problem hiding this comment.
Yep. Could be helpful if you know your target environment won't have a KV store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2715
Shows how we can handle initial configuration of factors by handling the initial key-value pairs for the default key-value store.