Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LlmCompute::into_engine type inference #2771

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix LlmCompute::into_engine type inference #2771

merged 1 commit into from
Aug 27, 2024

Conversation

lann
Copy link
Collaborator

@lann lann commented Aug 27, 2024 •
edited
Loading 

expected struct `Arc<tokio::sync::Mutex<NoopLlmEngine>>`
   found struct `Arc<tokio::sync::Mutex<RemoteHttpLlmEngine>>`

@lann
Fix LlmCompute::into_engine type inference
783e7b2 
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann requested a review from rylev August 27, 2024 12:30
@rylev rylev merged commit c6ad6b5 into spinframework:factors Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lann @rylev