Move outbound networking config to new crate #3167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
approved these changes
Jun 18, 2025
Collaborator
lann
left a comment
lann
left a comment
There was a problem hiding this comment.
Assuming no sneaky refactoring ...
Collaborator
|
YESSSSSSSSSSSSSSSSS |
rylev
force-pushed
the
outbound-networking-config
branch
from
5ca8eaf to
50ead3c
Compare
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rylev
force-pushed
the
outbound-networking-config
branch
from
50ead3c to
6333c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration for outbound networking is used in a lot of places outside of the outbound networking factor (e.g., in `spin-test). Instead of requiring pulling in the entire factor (with its heavy dependencies), we allow functionality related to the config to be pulled in separately.