variables: Refactor Provider::kind into ::may_resolve #3282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
commented
Oct 1, 2025
| /// | ||
| /// Dynamic resolvers will typically return true unconditionally, which is | ||
| /// the default implementation. | ||
| fn may_resolve(&self, key: &Key) -> bool { |
Collaborator
Author
There was a problem hiding this comment.
I'm trying to capture some subtlety in the name here: a Provider should only return false if it "knows" resolution would later fail; it is always safe to return true.
itowlson
approved these changes
Oct 1, 2025
| if !resolved { | ||
| unvalidated_keys.push(key); | ||
| let mut unresolvable_keys = vec![]; | ||
| for key in self.internal.required_variables() { |
Collaborator
There was a problem hiding this comment.
One thing I liked about the previous approach was that it allowed for a quick upfront check: do we have any dynamic providers in the mix, if so don't bother with checking individual variables. But in practice I guess the performance overhead of always checking every variable is insignificant.
Collaborator
Author
There was a problem hiding this comment.
I wouldn't be surprised if we saved more cycles in a single CI run by these tests no longer needing to set up a tokio runtime than we ever lose to this deoptimization. 🙂
lann
force-pushed
the
provider-may-resolve
branch
3 times, most recently
from
95e6709 to
363a537
Compare
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
provider-may-resolve
branch
from
363a537 to
294ad3a
Compare
fibonacci1729
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to avoid the implicit calls to
getrequired by the current implementation. I'm not attached to specifics here otherwise.