allow ci to collect logs on failure #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatjindal
requested review from
Mossaka,
kate-goldenring,
jsturtevant,
radu-matei and
devigned
as code owners
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
rajatjindal
force-pushed
the
collect-logs-from-ci
branch
from
1bfcd6c
to
93f2afe
Compare
There was a problem hiding this comment.
@rajatjindal have to tested this with a failing workflow to make sure the log file is uploaded with the expected format?
|
yeah, it helped me debug the issue in my other PR: https://github.com/spinkube/containerd-shim-spin/actions/runs/8523555191 |
kate-goldenring
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on failure, it will be nice to collect some debug logs that can help in debugging further. e.g. I am trying to debug this failure
I saw that we collect some info in
workloads.sh, but that won't be collected if the script fails before that.