update redis crate to 0.25 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatjindal
requested review from
Mossaka,
kate-goldenring,
jsturtevant,
radu-matei and
devigned
as code owners
kate-goldenring
approved these changes
Apr 10, 2024
devigned
approved these changes
Apr 10, 2024
| @@ -57,7 +57,7 @@ mod test { | |||
| port_forward_redis(forward_port, redis_port).await?; | |||
|
|
|||
| let client = redis::Client::open(format!("redis://localhost:{}", forward_port))?; | |||
| let mut con = client.get_async_connection().await?; | |||
| let mut con = client.get_multiplexed_async_connection().await?; | |||
There was a problem hiding this comment.
Deprecated: aio::Connection is deprecated. Use client::get_multiplexed_async_connection instead.
per: https://docs.rs/redis/latest/src/redis/client.rs.html#77
|
@rajatjindal, it looks like the commit was not signed. Would you amend the commit and sign it? |
Mossaka
approved these changes
Apr 10, 2024
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
rajatjindal
force-pushed
the
update-redis
branch
from
f2bb019
to
3792e78
Compare
|
👍 signed the commit now (pushed it from a new dev box). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this supersedes #75