Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(google): make AbstractAtomicOperationsCredentialsConverter generic type #5866

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix(google): make AbstractAtomicOperationsCredentialsConverter generic type #5866

merged 1 commit into from
Feb 14, 2023

Conversation

kirangodishala
Copy link
Contributor

There are a couple of classes which extended AbstractAtomicOperationsCredentialsConverter but without being a generic type causing it to work fine with google accounts alone but fails when kubernetes accounts get added.
This PR will fix the issue (#6796)

sanopsmx
sanopsmx approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@sanopsmx sanopsmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@j-sandy j-sandy merged commit 27ed951 into spinnaker:master Feb 14, 2023
@j-sandy
Copy link
Contributor

j-sandy commented Feb 14, 2023

@Mergifyio backport release-1.29.x

@mergify mergify bot mentioned this pull request Feb 14, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2023

backport release-1.29.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 14, 2023
@kirangodishala @mergify
fix(google): make AbstractAtomicOperationsCredentialsConverter generi…
a3658f3 
…c type (#5866)

(cherry picked from commit 27ed951)
mergify bot added a commit that referenced this pull request Feb 14, 2023
@mergify @kirangodishala
fix(google): make AbstractAtomicOperationsCredentialsConverter generi…
56f13ef 
…c type (#5866) (#5875)

(cherry picked from commit 27ed951)

Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
@kirangodishala kirangodishala mentioned this pull request Jun 5, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgogerly mattgogerly mattgogerly approved these changes

@sanopsmx sanopsmx sanopsmx approved these changes

@plumpy plumpy Awaiting requested review from plumpy plumpy is a code owner

@skandragon skandragon Awaiting requested review from skandragon skandragon is a code owner

Assignees
No one assigned
Labels
target-release/1.30
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kirangodishala @j-sandy @mattgogerly @sanopsmx @spinnakerbot