fix(manifest-replicas): ReplicaSet Source-Capacity

[nhtzr]

Change: Use version suffixes to populate replicas when using use-source-capacity annotation

[nhtzr]

@Mergifyio backport release-1.28.x release-1.27.x

[mergify]

backport release-1.28.x release-1.27.x

❌ Command disallowed due to command restrictions in the Mergify configuration.

• sender-permission>=write

[mattgogerly]

Can you explain what's currently broken and how this fixes it?

[nhtzr]

@mattgogerly use-source-capacity annotation is meant to query the currently used replicas field from the manifest in the cluster. The behavior seems to run fine with non-versioned manifests. However, the current implementation fails to take into account the versioning that spinnaker usually adds to ReplicaSets. The fix introduces extra to logic to query the replicas field from the correct manifest name.

[mrampton]

@nhtzr -- would you mind adding some tests?

[nhtzr]

@mrampton updated

[nhtzr]

@spinnaker/reviewers Hi, please let me know if I'm missing anything.

[nhtzr]

@ovidiupopa07 Hi, please let me know if I'm missing anything.

[ovidiupopa07]

LGTM. Would it make sense to also add an IT for this? (there are already ITs written for the Deploy manifest operation)

[nhtzr]

Added Integration tests for both use-source-capacity cases

[ovidiupopa07]

Lgtm

[ovidiupopa07]

@Mergifyio update

[mergify]

update

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@armory needs to authorize modification on its head branch.
err-code: D0DED