chore(dependency): add explicit dependency of groovy-templates in clouddriver-kubernetes while upgrading groovy 3.x #6053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uddriver-kubernetes while upgrading groovy 3.x While upgrading groovy 3.0.10 and spockframework 2.0-groovy-3.0, groovy-templates is not part of [spockframework](https://mvnrepository.com/artifact/org.spockframework/spock-core/2.0-groovy-3.0) and encounter below error during test compilation: ``` > Task :clouddriver-kubernetes:compileTestGroovy FAILED startup failed: /clouddriver/clouddriver-kubernetes/src/test/groovy/com/netflix/spinnaker/clouddriver/kubernetes/description/KubernetesManifestSpec.groovy: 25: unable to resolve class groovy.text.SimpleTemplateEngine @ line 25, column 1. import groovy.text.SimpleTemplateEngine ^ 1 error ``` So, adding explicit dependency of groovy-templates in clouddriver-kubernetes.gradle With groovy 2.5.15 and spockframework 1.3-groovy-2.5, groovy-templates appear as transitive dependency of [spockframework](https://mvnrepository.com/artifact/org.spockframework/spock-core/1.3-groovy-2.5) as shown below: ```$ ./gradlew clouddriver-kubernetes:dI --dependency groovy-templates --configuration testCompileClasspath Starting a Gradle Daemon, 34 stopped Daemons could not be reused, use --status for details > Task :clouddriver-kubernetes:dependencyInsight org.codehaus.groovy:groovy-templates:2.5.15 Variant compile: | Attribute Name | Provided | Requested | |------------------------------------|----------|-------------------| | org.gradle.status | release | | | org.gradle.category | library | library | | org.gradle.libraryelements | jar | classes+resources | | org.gradle.usage | java-api | java-api | | org.gradle.dependency.bundling | | external | | org.gradle.jvm.environment | | standard-jvm | | org.gradle.jvm.version | | 11 | | org.jetbrains.kotlin.platform.type | | jvm | Selection reasons: - By constraint - Forced org.codehaus.groovy:groovy-templates:2.5.15 \--- io.spinnaker.kork:kork-bom:7.190.0 \--- testCompileClasspath org.codehaus.groovy:groovy-templates:2.5.4 -> 2.5.15 +--- org.spockframework:spock-core:1.3-groovy-2.5 | +--- testCompileClasspath (requested org.spockframework:spock-core) | +--- io.spinnaker.kork:kork-bom:7.190.0 | | \--- testCompileClasspath | \--- org.spockframework:spock-spring:1.3-groovy-2.5 | +--- testCompileClasspath (requested org.spockframework:spock-spring) | \--- io.spinnaker.kork:kork-bom:7.190.0 (*) \--- org.spockframework:spock-spring:1.3-groovy-2.5 (*) ```
dbyron-sf
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading groovy 3.0.10 and spockframework 2.0-groovy-3.0, groovy-templates is not part of spockframework and encounter below error during test compilation:
So, adding explicit dependency of groovy-templates in clouddriver-kubernetes.gradle
With groovy 2.5.15 and spockframework 1.3-groovy-2.5, groovy-templates appear as transitive dependency of spockframework as shown below: