Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cats): timeoutSeconds and errorIntervalSeconds config are not respected #6105

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix(cats): timeoutSeconds and errorIntervalSeconds config are not respected #6105

merged 1 commit into from
Nov 20, 2023

Conversation

huynhsontung
Copy link
Contributor

Fixed redis.poll.errorIntervalSeconds and redis.poll.timeoutSeconds configs are not respected. This bug was introduced when converting RedisCacheConfig from Groovy to Java. See related PR.

@huynhsontung huynhsontung changed the title fix(cats): passsing incorrect redis config into interval provider fix(cats): timeoutSeconds and errorIntervalSeconds config are not respected Nov 20, 2023
@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • f98aa81: fix passsing incorrect redis config into interval provider

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for a merge label Nov 20, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Nov 20, 2023
@mergify mergify bot merged commit 0501650 into spinnaker:master Nov 20, 2023
16 checks passed
@dbyron-sf
Copy link
Contributor

@Mergifyio backport release-1.29.x release-1.30.x release-1.31.x release-1.32.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2023 •
edited
Loading

backport release-1.29.x release-1.30.x release-1.31.x release-1.32.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 20, 2023
@huynhsontung @mergify
fix(cats): passing incorrect redis config into interval provider (#6105)
2b77e19 
Co-authored-by: Tung Huynh <s2.huynh@samsung.com>
(cherry picked from commit 0501650)
@mergify mergify bot mentioned this pull request Nov 20, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 20, 2023
@huynhsontung @mergify
fix(cats): passing incorrect redis config into interval provider (#6105)
419bbee 
Co-authored-by: Tung Huynh <s2.huynh@samsung.com>
(cherry picked from commit 0501650)
@mergify mergify bot mentioned this pull request Nov 20, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 20, 2023
@huynhsontung @mergify
fix(cats): passing incorrect redis config into interval provider (#6105)
17cb7bc 
Co-authored-by: Tung Huynh <s2.huynh@samsung.com>
(cherry picked from commit 0501650)
@mergify mergify bot mentioned this pull request Nov 20, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 20, 2023
@huynhsontung @mergify
fix(cats): passing incorrect redis config into interval provider (#6105)
4f24103 
Co-authored-by: Tung Huynh <s2.huynh@samsung.com>
(cherry picked from commit 0501650)
@mergify mergify bot mentioned this pull request Nov 20, 2023
Merged
@dbyron-sf
Copy link
Contributor

Thank you @huynhsontung !

mergify bot added a commit that referenced this pull request Nov 20, 2023
@mergify @huynhsontung
fix(cats): passing incorrect redis config into interval provider (#6105…
eeaeb79 
…) (#6106)

Co-authored-by: Tung Huynh <s2.huynh@samsung.com>
(cherry picked from commit 0501650)

Co-authored-by: Tung Huynh <31434093+huynhsontung@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Nov 20, 2023
@mergify @huynhsontung
fix(cats): passing incorrect redis config into interval provider (#6105…
05ecbef 
…) (#6108)

Co-authored-by: Tung Huynh <s2.huynh@samsung.com>
(cherry picked from commit 0501650)

Co-authored-by: Tung Huynh <31434093+huynhsontung@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Nov 20, 2023
@mergify @huynhsontung
fix(cats): passing incorrect redis config into interval provider (#6105…
75e00c7 
…) (#6107)

Co-authored-by: Tung Huynh <s2.huynh@samsung.com>
(cherry picked from commit 0501650)

Co-authored-by: Tung Huynh <31434093+huynhsontung@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Nov 20, 2023
@mergify @huynhsontung
fix(cats): passing incorrect redis config into interval provider (#6105…
51475a1 
…) (#6109)

Co-authored-by: Tung Huynh <s2.huynh@samsung.com>
(cherry picked from commit 0501650)

Co-authored-by: Tung Huynh <31434093+huynhsontung@users.noreply.github.com>
@huynhsontung huynhsontung deleted the fix-redis-config branch November 20, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

@cfieber cfieber Awaiting requested review from cfieber cfieber is a code owner

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.33
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huynhsontung @spinnakerbot @dbyron-sf