Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubernetes): use getFullResourceName in KubectlJobExecutor.create #6117

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix(kubernetes): use getFullResourceName in KubectlJobExecutor.create #6117

merged 1 commit into from
Nov 29, 2023

Conversation

dbyron-sf
Copy link
Contributor

to get a meaningful manifest name when using generateName instead of name

@dbyron-sf
fix(kubernetes): use getFullResourceName in KubectlJobExecutor.create
4d43d69 
to get a meaningful manifest name when using generateName instead of name
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for a merge label Nov 29, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Nov 29, 2023
@mergify mergify bot merged commit 738e5ed into spinnaker:master Nov 29, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmcintosh jasonmcintosh jasonmcintosh approved these changes

@clanesf clanesf Awaiting requested review from clanesf clanesf is a code owner

@german-muzquiz german-muzquiz Awaiting requested review from german-muzquiz german-muzquiz is a code owner

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.33
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbyron-sf @jasonmcintosh @spinnakerbot