Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(databaseChangeLog): fix for 'addAfterColumn is not allowed on postgresql' #6194

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix(databaseChangeLog): fix for 'addAfterColumn is not allowed on postgresql' #6194

merged 1 commit into from
Apr 19, 2024

Conversation

kirangodishala
Copy link
Contributor

This PR addresses spinnaker/spinnaker#6942

The following PR provides more details on the issue and similar fix provided for orca: spinnaker/orca#4594

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for a merge label Apr 19, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Apr 19, 2024
@mergify mergify bot merged commit db8897c into spinnaker:master Apr 19, 2024
24 checks passed
@dbyron-sf dbyron-sf mentioned this pull request Apr 19, 2024
Closed
@dbyron-sf
Copy link
Contributor

@Mergifyio backport release-1.33.x release-1.34.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 19, 2024 •
edited
Loading

backport release-1.33.x release-1.34.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 19, 2024
@kirangodishala @mergify
fix(databaseChangeLog): fix for 'addAfterColumn is not allowed on pos…
ade4da8 
…tgresql' (#6194)

(cherry picked from commit db8897c)
@mergify mergify bot mentioned this pull request Apr 19, 2024
Merged
mergify bot pushed a commit that referenced this pull request Apr 19, 2024
@kirangodishala @mergify
fix(databaseChangeLog): fix for 'addAfterColumn is not allowed on pos…
b03e64a 
…tgresql' (#6194)

(cherry picked from commit db8897c)
@mergify mergify bot mentioned this pull request Apr 19, 2024
Merged
mergify bot added a commit that referenced this pull request Apr 19, 2024
@mergify @kirangodishala
fix(databaseChangeLog): fix for 'addAfterColumn is not allowed on pos…
ab0d436 
…tgresql' (#6194) (#6196)

(cherry picked from commit db8897c)

Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Apr 19, 2024
@mergify @kirangodishala
fix(databaseChangeLog): fix for 'addAfterColumn is not allowed on pos…
891edd3 
…tgresql' (#6194) (#6195)

(cherry picked from commit db8897c)

Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
This was referenced May 22, 2024
Merged
Closed
@xibz
Copy link
Contributor

xibz commented May 23, 2024

How difficult would it be to have a containerized test for this? Similar to what we do for redis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirangodishala @dbyron-sf @xibz