fix(ClusterController): Fix GetClusters to return all providers clusterNames of an application #6210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viders clusterNames of application
jasonmcintosh
approved these changes
May 15, 2024
|
@Mergifyio backport release-1.32.x release-1.33.x release-1.34.x |
✅ Backports have been created
|
aman-agrawal
pushed a commit
to aman-agrawal/clouddriver
that referenced
this pull request
Jul 5, 2024
…viders clusterNames of application (spinnaker#6210) (spinnaker#6212) (cherry picked from commit c9bba66) Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
aman-agrawal
pushed a commit
to OpsMx/clouddriver-oes
that referenced
this pull request
Jul 8, 2024
…viders clusterNames of application (spinnaker#6210) (spinnaker#6212) (cherry picked from commit c9bba66) Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an application includes clusters for more than 2 cloud-providers then the GET /clusters endpoint was returning only the last 2 providers clusterNames instead of ALL the clusters deployed by the application.
We didnt notice this bug existed because Deck is rendering based on the clusters and serverGroups and when not filtered the serverGroups was including the missing clusters.
It is noticeable though for the end-user when the SETTINGS.onDemandClusterThreshold is used to make a searchable rendering of clusters/serverGroups in Deck.