Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(googlecloudsdkversion): Upgraded the google cloud sdk version from 412.0.0 to 476.0.0 in clouddriver. #6216

Merged
merged 1 commit into from
May 27, 2024

Conversation

sanopsmx
Copy link
Contributor

spinnaker/spinnaker#6954

Upgraded the google cloud sdk version from 412.0.0 to 476.0.0

Upgraded both Docker java 11 & 17 files.

Tested the deployments and working fine.

@sanopsmx
Copy link
Contributor Author

sanopsmx commented May 21, 2024

@j-sandy @kirangodishala @mattgogerly @plumpy
Pls can you review these changes and provide your feedback.

@mattgogerly
Copy link
Member

I forget what the SDK is used for - is it just authentication? Have there been any notable or breaking changes between these versions?

@sanopsmx
Copy link
Contributor Author

I forget what the SDK is used for - is it just authentication? Have there been any notable or breaking changes between these versions?

Yes ,authentication, authorization and deployment. Do not see any breaking changes.

Here is the link of the 476.0.0 version release notes.

https://cloud.google.com/sdk/docs/release-notes

@sanopsmx
Copy link
Contributor Author

@mattgogerly

I see the major app engine update from 476.0.0.

App Engine

Use java21 as the default runtime for app.yaml generated configuration. This change is compatible with gcloud app deploy command, when there is no app.yaml configuration for Java projects (Maven, or Gradle, or simple jar). Instead of using a java17 runtime target, App Engine deploys the application using the java21 runtime with an F2 instance class. To continue using the java17 runtime, create an app.yaml file, and specify runtime: java17.

Updated the Java SDK to version 2.0.27 build from the open source project https://github.com/GoogleCloudPlatform/appengine-java-standard/releases/tag/v2.0.27.

Copy link
Member

@nemesisOsorio nemesisOsorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nemesisOsorio nemesisOsorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change other Docker files like Dockerfile.slim?

@sanopsmx
Copy link
Contributor Author

should we change other Docker files like Dockerfile.slim?

Yes...good catch.....Modified the slim files as well.

@sanopsmx
Copy link
Contributor Author

@mattgogerly

I see the major app engine update from 476.0.0.

App Engine

Use java21 as the default runtime for app.yaml generated configuration. This change is compatible with gcloud app deploy command, when there is no app.yaml configuration for Java projects (Maven, or Gradle, or simple jar). Instead of using a java17 runtime target, App Engine deploys the application using the java21 runtime with an F2 instance class. To continue using the java17 runtime, create an app.yaml file, and specify runtime: java17.

Updated the Java SDK to version 2.0.27 build from the open source project https://github.com/GoogleCloudPlatform/appengine-java-standard/releases/tag/v2.0.27.

Appengine deployments working fine. attached screenshots.
Screenshot from 2024-05-23 14-28-28
Screenshot from 2024-05-23 14-28-33

@j-sandy j-sandy added the ready to merge Approved and ready for a merge label May 24, 2024
@j-sandy j-sandy merged commit 9e909e0 into spinnaker:master May 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Approved and ready for a merge target-release/1.35
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants