-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config(googlecloudsdkversion): Upgraded the google cloud sdk version from 412.0.0 to 476.0.0 in clouddriver. #6216
Conversation
@j-sandy @kirangodishala @mattgogerly @plumpy |
I forget what the SDK is used for - is it just authentication? Have there been any notable or breaking changes between these versions? |
Yes ,authentication, authorization and deployment. Do not see any breaking changes. Here is the link of the 476.0.0 version release notes. |
I see the major app engine update from 476.0.0. App Engine Use java21 as the default runtime for app.yaml generated configuration. This change is compatible with gcloud app deploy command, when there is no app.yaml configuration for Java projects (Maven, or Gradle, or simple jar). Instead of using a java17 runtime target, App Engine deploys the application using the java21 runtime with an F2 instance class. To continue using the java17 runtime, create an app.yaml file, and specify runtime: java17. Updated the Java SDK to version 2.0.27 build from the open source project https://github.com/GoogleCloudPlatform/appengine-java-standard/releases/tag/v2.0.27. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we change other Docker files like Dockerfile.slim
?
Yes...good catch.....Modified the slim files as well. |
…from 412.0.0 to 476.0.0 in clouddriver.
|
spinnaker/spinnaker#6954
Upgraded the google cloud sdk version from 412.0.0 to 476.0.0
Upgraded both Docker java 11 & 17 files.
Tested the deployments and working fine.