-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(google): fixing UpsertGoogleAutoscalingPolicyAtomicOperation missing Autowired for objectMapper and cacheView #6237
Merged
mergify
merged 3 commits into
spinnaker:master
from
shlomodaari:fixing-cacheview-objectmapper
Jun 25, 2024
Merged
fix(google): fixing UpsertGoogleAutoscalingPolicyAtomicOperation missing Autowired for objectMapper and cacheView #6237
mergify
merged 3 commits into
spinnaker:master
from
shlomodaari:fixing-cacheview-objectmapper
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding autowired for cacheview and objectmapper for UpsertGoogleAutoscalingPolicyAtomicOperation
Can you add a test that demonstrates the bug? |
@dbyron-sf I updated the tests that it will check for this. |
Sorry, didn't see it there, thanks! |
jasonmcintosh
approved these changes
Jun 25, 2024
@Mergifyio backport release-1.33.x release-1.34.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…ing Autowired for objectMapper and cacheView (#6237) * fix(google): adding autowired for cacheview and objectmapper adding autowired for cacheview and objectmapper for UpsertGoogleAutoscalingPolicyAtomicOperation * fix(google): adding autowired for cacheview and objectmapper --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit f125906)
mergify bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…ing Autowired for objectMapper and cacheView (#6237) * fix(google): adding autowired for cacheview and objectmapper adding autowired for cacheview and objectmapper for UpsertGoogleAutoscalingPolicyAtomicOperation * fix(google): adding autowired for cacheview and objectmapper --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit f125906)
This was referenced Jun 26, 2024
mergify bot
added a commit
that referenced
this pull request
Jun 27, 2024
…ing Autowired for objectMapper and cacheView (#6237) (#6240) * fix(google): adding autowired for cacheview and objectmapper adding autowired for cacheview and objectmapper for UpsertGoogleAutoscalingPolicyAtomicOperation * fix(google): adding autowired for cacheview and objectmapper --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit f125906) Co-authored-by: Shlomo Daari <104773977+shlomodaari@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Jun 27, 2024
…ing Autowired for objectMapper and cacheView (#6237) (#6241) * fix(google): adding autowired for cacheview and objectmapper adding autowired for cacheview and objectmapper for UpsertGoogleAutoscalingPolicyAtomicOperation * fix(google): adding autowired for cacheview and objectmapper --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit f125906) Co-authored-by: Shlomo Daari <104773977+shlomodaari@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto merged
Merged automatically by a bot
ready to merge
Approved and ready for a merge
target-release/1.35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the following issue
It was introduced as part of this PR