Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google): fixing UpsertGoogleAutoscalingPolicyAtomicOperation missing Autowired for objectMapper and cacheView #6237

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

shlomodaari
Copy link
Contributor

Fixing the following issue
It was introduced as part of this PR

shlomodaari and others added 2 commits June 20, 2024 15:40
adding autowired for cacheview and objectmapper for UpsertGoogleAutoscalingPolicyAtomicOperation
@dbyron-sf
Copy link
Contributor

Can you add a test that demonstrates the bug?

@shlomodaari
Copy link
Contributor Author

@dbyron-sf I updated the tests that it will check for this.
Previously, the tests didn't cover it, so we couldn't see it failing.

@shlomodaari
Copy link
Contributor Author

image

@dbyron-sf
Copy link
Contributor

Sorry, didn't see it there, thanks!

@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for a merge label Jun 25, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Jun 25, 2024
@mergify mergify bot merged commit f125906 into spinnaker:master Jun 25, 2024
23 checks passed
@jasonmcintosh
Copy link
Member

@Mergifyio backport release-1.33.x release-1.34.x

Copy link
Contributor

mergify bot commented Jun 26, 2024

mergify bot pushed a commit that referenced this pull request Jun 26, 2024
…ing Autowired for objectMapper and cacheView (#6237)

* fix(google): adding autowired for cacheview and objectmapper

adding autowired for cacheview and objectmapper for UpsertGoogleAutoscalingPolicyAtomicOperation

* fix(google): adding autowired for cacheview and objectmapper

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit f125906)
mergify bot pushed a commit that referenced this pull request Jun 26, 2024
…ing Autowired for objectMapper and cacheView (#6237)

* fix(google): adding autowired for cacheview and objectmapper

adding autowired for cacheview and objectmapper for UpsertGoogleAutoscalingPolicyAtomicOperation

* fix(google): adding autowired for cacheview and objectmapper

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit f125906)
mergify bot added a commit that referenced this pull request Jun 27, 2024
…ing Autowired for objectMapper and cacheView (#6237) (#6240)

* fix(google): adding autowired for cacheview and objectmapper

adding autowired for cacheview and objectmapper for UpsertGoogleAutoscalingPolicyAtomicOperation

* fix(google): adding autowired for cacheview and objectmapper

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit f125906)

Co-authored-by: Shlomo Daari <104773977+shlomodaari@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Jun 27, 2024
…ing Autowired for objectMapper and cacheView (#6237) (#6241)

* fix(google): adding autowired for cacheview and objectmapper

adding autowired for cacheview and objectmapper for UpsertGoogleAutoscalingPolicyAtomicOperation

* fix(google): adding autowired for cacheview and objectmapper

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit f125906)

Co-authored-by: Shlomo Daari <104773977+shlomodaari@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.35
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants