feat(kubernetes): Skip applying labels to spec.template.metadata if skipSpecTemplateLabels is true #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunalsharma05
requested review from
jeyrschabu,
ajordens,
cfieber,
zachsmith1,
plumpy,
skandragon,
clanesf and
german-muzquiz
as code owners
added 2 commits
July 30, 2024 14:20
…n.OperationDescription to kork-moniker Moved the OperationDescription from clouddriver-api to kork-moniker and updated all the relevant references. This will allow us to pass Manifest Description to the Namer class.
…kipSpecTemplateLabels is true Setting skipSpecTemplateLabels to true, clouddriver will not apply the app.kubernetes.io/* labels to the manifests' spec.template.metadata.labels.
kunalsharma05
force-pushed
the
skip-spec-template-labels
branch
from
9e12a38
to
d35f304
Compare
|
@Mergifyio update |
✅ Branch has been successfully updated |
dbyron-sf
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the OperationDescription from clouddriver-api to kork-moniker and updated all the relevant references. This will allow us to pass Manifest Description to the Namer class.
Setting skipSpecTemplateLabels to true, clouddriver will not apply the app.kubernetes.io/* labels to the manifests' spec.template.metadata.labels.
Kork PR that needs to be included prior to this: spinnaker/kork#1199