fix(core): Do not set static document base URL (#9890)

The previous change to enable optional path-based routing (#9802) added a `<base>` tag, which regressed serving hash-based routing at non-root public paths. This change returns to AngularJS's default behavior when using hash-based routing. Note that path-based routing will continue to only function when served from a domain root. Resolves spinnaker/spinnaker#6723 (cherry picked from commit 5ac7516)
spinnaker · Oct 6, 2022 · beb2bf7 · beb2bf7
1 parent 8cc8293
commit beb2bf7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/packages/app/index.deck b/packages/app/index.deck
@@ -5,7 +5,6 @@
   <meta charset="utf-8">
   <meta name="description" content="">
   <meta name="viewport" content="width=device-width">
-  <base href="/">
 
   <!-- Sample loading styles -->
   <style>

diff --git a/packages/core/src/bootstrap/angular.config.ts b/packages/core/src/bootstrap/angular.config.ts
@@ -38,6 +38,7 @@ bootstrapModule.config([
     $locationProvider.html5Mode({
       enabled: SETTINGS.feature.html5Routing,
       rewriteLinks: false,
+      requireBase: false,
     });
   },
 ]);