fix(google): Add partner metadata on clone #10161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chConfig when clone serverGroup
jasonmcintosh
approved these changes
Jan 17, 2025
|
@mergify backport release-1.36.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
* fix(google): populate resourceManagerTags & partnerMetadata when cloning server group * fix(google): add logs for debug * fix(google): populate resourceManagerTags & partnerMetadata from launchConfig when clone serverGroup (cherry picked from commit 3005516)
This was referenced Jan 21, 2025
edgarulg
added a commit
that referenced
this pull request
Jan 21, 2025
* fix(google): populate resourceManagerTags & partnerMetadata when cloning server group * fix(google): add logs for debug * fix(google): populate resourceManagerTags & partnerMetadata from launchConfig when clone serverGroup (cherry picked from commit 3005516) Co-authored-by: Edgar Garcia <63310723+edgarulg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
When cloning a server group using the UI. The resourceManagerTags and partnerMetadata are not populated even if the deployment is configured with resourceManagerTags and partnerMetadata.
Expected Behavior
If the server group has resourceManagerTags and partnerMetadata configured. Cloning the server group should populate these fields automatically.
The main issue comes from Clouddriver because the instanceTemplate doesn't include the partner metadata. See: spinnaker/clouddriver#6334
In Deck, we just populate the resourceManagerTags and partnerMetadata in the instanceTemplateProperties under the lauchConfiguration.